Repository navigation
Conversation
Signed-off-by: Amir Baqdadi <ahbaqdadi@gmail.com>
|
Thanks for this. Aligning One thing worth keeping in mind, though: even with this PR the two are not strictly equivalent, because the initial sync still re-implements the rules instead of sharing them. That is the same kind of mismatch as #14439, and it does not have to be solved here. It would be good to say in the description that this PR aligns the |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
What this PR does
Makes
develop.watch.initial_syncrespect nesteddevelop.watch.ignoreand.dockerignorepaths so excluded files are not copied into the container.Related issue
Fixes #14439
Changes made
.git, Dockerfile, and Compose file exclusions at any depth; keep walking ignored directories when a negated rule includes a child..dockerignore, negated ignore patterns, single-file triggers, and fully ignored directories.Testing done
make testDOCKER_CONTEXT=desktop-linux make e2e-compose-standalone E2E_TEST='^TestWatchLegacyXInitialSync$'make lint(0 issues)make fmtmake validatein an identical standalone clone (the linked worktree's.gitpointer is unavailable to its Docker vendor check)Scope and follow-up
This PR aligns initial sync's
develop.watch.ignoreand.dockerignorehandling with live watch. Initial sync still does not applydevelop.watch.include; sharing the watch rule construction between the two paths is a separate follow-up.Open PR #14217 also touches watch ignore handling and may require a rebase.