[xperiandri]

Stacked on #20894

fst, snd, isNull, box and the math functions on primitive types now reach LINQ providers as tuple reads, null comparisons, conversions and System.Math calls instead of calls into FSharp.Core that no provider knows.

Details

• The math functions are abs, sqrt, floor, ceil, round, truncate, sign, exp, log, log10, the trigonometric and hyperbolic functions, min, max, atan2 and **. Other types keep the F# implementation.
• A compiled tree gives what the F# function gives in code. For min and max on float and float32 that differs from before when an argument is NaN or the arguments are zeros of different sign.
• A provider that translates Math.Round rounds midpoints its own way; SQLite rounds them away from zero.

🤖 Generated with Claude Code

[github-actions]

✅ Release notes checked

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
`src/FSharp.Core`	docs/release-notes/.FSharp.Core/11.0.200.md

[xperiandri]

Covered cases

EF Core SQLite translates 115 of 153 scenarios, 94 without this change, in queries and in Where and Select lambdas: min, max, floor, ceil, round, truncate, sqrt, **, exp, log, log10, the trigonometric and hyperbolic functions, sqrt of a float32, fst and snd after select … into and of a let-bound tuple, isNull, and box x = null.

Cosmos translates 31 scenarios, up from 18.

Not translated: abs and sign in one where, because EF Core SQLite has no translation for Math.Sign. Cosmos translates it.

[Copilot]

🟡 Changes recommended

Tuple reductions can discard user-created tuple-element evaluations and suppress expected exceptions, while join analysis misses unnamed tuples in inner sources.

2 open issues

• Preserve evaluation of discarded user tuple elements · New
• Analyze inner sources for unnamed tuple member reads · New

What changed in this PR

This PR makes FSharp.Core’s LINQ translation emit standard expression nodes and System.Math calls that providers can recognize. It builds on #20894’s struct-tuple support and query-shape tests.

Changes:

• Translate tuple access, null checks, boxing, and primitive math operators into provider-friendly expressions.
• Add query scenarios and expression tests covering tree structure and compiled behavior.
• Document expression-tree changes, including floating-point min/max behavior and provider-specific rounding.

File	Description
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryStructureScenarios.fs	Cover loops, subqueries, and left joins.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryShapeTests.fs	Register scenario-based query tests.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryScenarioDomain.fs	Supply shared query entities and data.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryScenario.fs	Compare query results and expected tree violations.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryProviderShape.fs	Capture queries and detect unsupported tree shapes.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryProjectionScenarios.fs	Cover tuple, record, and object projections.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryOperatorScenarios.fs	Cover filtering, sorting, joins, and aggregates.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryMethodSyntaxScenarios.fs	Exercise LINQ method-syntax expressions.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryKeyScenarios.fs	Cover composite join and grouping keys.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​QueryFSharpOperatorScenarios.fs	Exercise F# operators in provider queries.
tests/​FSharp.Core.UnitTests/​FSharp.Core/​Microsoft.FSharp.Linq/​ExpressionFSharpOperatorTests.fs	Check translated nodes and compiled operator results.
tests/​FSharp.Core.UnitTests/​FSharp.Core.UnitTests.fsproj	Include the new test files.
src/​FSharp.Core/​QueryExtensions.fs	Adapt struct tuples while preserving tuple kind.
src/​FSharp.Core/​Query.fs	Expand fst/snd and reconstruct struct tuples.
src/​FSharp.Core/​Linq.fs	Translate operators and struct-tuple field reads.
docs/​release-notes/​PENDING_BREAKING_CHANGES.md	Explain tree-shape and behavioral compatibility changes.
docs/​release-notes/​.FSharp.Core/​11.0.200.md	Add struct-tuple and operator translation release notes.

_{Review effort: Balanced}

[pcshrosbree]

At the current head, the tree results for the changed functions match compiled F# in every edge case I checked, including four min and max cases where main's tree does not. Please document the incorrect SQLite results for decimal min and max in PENDING_BREAKING_CHANGES.md and add max 1.0 nan to the test.

The edge values were abs of MinValue, sign nan, midpoint rounding on float and decimal, NaN and signed zero in min and max, isNull on a type with a custom ==, and box of a struct and of null. The four min and max cases are max 1.0 nan, min nan 1.0, max 1.0f nanf and max -0.0 0.0. Main's tree gives 1, 1, 1f and -0 for them; compiled F# and this PR give NaN, NaN, NaN and 0.

• Decimal min and max now reach EF Core 10.0.2 in this probe, and on SQLite, which stores decimals as text, they return wrong rows. With rows 2.5m and -1.25m, Where(fun x -> max x.D 10m = 10m) used to fail to translate. It now returns one row instead of two, from WHERE max("i"."D", '10.0') = '10.0'. C# Math.Max gets the same SQL, so this is EF Core's behaviour, but the note warns only about Math.Round.
• The NaN test asserts max nan 0.0, which already passes on #20894. Please also assert max 1.0 nan, which fails there.
• The "Was" line shows Call(Operators.Abs, x). For abs, round and the other functions with member constraints, the old tree called the witness overload, Operators.Abs$W(FuncConvert.ToFSharpFunc(..), x).

[T-Gro]

🤖 🕵️ LGTM

Dismissed: SQLite decimal min/max behavior, warning documentation, NaN/abs coverage, and the workflow gate remain unresolved.

[xperiandri]

Thanks @pcshrosbree. Changes since 157fc5b:

• 0f10296 adds max 1.0 nan, min nan 1.0 and max 1.0f nanf to Compiled min and max give NaN when the other argument is NaN, as the F# functions do. They fail on Check query trees for LINQ providers and translate struct tuples #20894 and pass here. max -0.0 0.0 is covered by the test that was there.
• PENDING_BREAKING_CHANGES.md warns about decimal min and max on SQLite as well as Math.Round: they reach EF Core now and return wrong rows from max("i"."D", '10.0'), as C# Math.Max does.
• The "Was" line shows the witness overload, Call(Operators.Abs$W, ToFSharpFunc(..), x), which I checked in F# Interactive.

[T-Gro]

🤖 🕵️ Re-reviewed all recent changes as of 0f10296; 1 finding