Repository navigation
FIX: surface failed suite entries behind cancellations - #4094
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
The aggregate status checked CANCELLED before FAILED, so cancelling after a child run failed reported a clean cancellation and hid the failure from the suite summary. Failed work now outranks cancellation while pure cancellations keep reporting CANCELLED. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4093
The suite execution aggregate status checked CANCELLED before FAILED, so cancelling an execution after a child run failed reported a clean CANCELLED and hid the failure from the suite summary. Polling clients keying alerts or restart decisions off the summary got no signal that work actually failed, even though the operator cancelled precisely because of that failure.
Failed work now outranks cancellation in the aggregate. Pure cancellations keep reporting CANCELLED, and the existing pins for the failed and cancelled suites are unchanged.
Tests and Documentation
Added a regression driving the aggregate with a FAILED and a CANCELLED entry and asserting FAILED, plus the pure cancellation case. It fails on main, which reports CANCELLED for the mixed set. The suite execution service suite passes at 11 tests and ruff is clean.
No documentation change needed, so I did not run JupyText.