Repository navigation
gh-161571: Fix a crash in curses.tparm() with string parameters - #161601
Open
serhiy-storchaka wants to merge 1 commit into
Open
serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
curses passes the parameters that the format string formats with %s or %l after %p as char *, for example in the Ms capability of xterm. An integer there crashed it. Such parameters must now be bytes objects, which are passed as char *. The parameters are now a var-positional parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curses takes as
char *the parameters that the format string formats with%sor%lafter%pN, for example in theMsandCscapabilities of xterm.curses.tparm()passed all parameters as integers, so an integer there crashed.tparm()now finds these parameters in the format string, as ncurses does, and requires bytes objects for them, which it passes aschar *. An integer there raisesTypeError. The other parameters are integers, as before. An omitted parameter is still 0, which curses takes as an empty string for a string parameter.The parameters are now a var-positional parameter,
tparm(str, /, *params), with at most nine of them.curses.tparm()crashes for capabilities that take string parameters #161571🤖 Generated with Claude Code