Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a forward reference to a single name,
ForwardRef.evaluate()returned the closure cell's value before the owner class's namespace was considered, so a nonlocal won over a class attribute of the same name. The dict-of-cells path already lets the class namespace win, which is why David's example gave'nonlocal'forabutlist['local']forb.This skips the single-cell shortcut when no explicit
localsare passed, the owner is a class, and the name is defined in that class. As Jelle said on the issue, explicitglobals/localsare not meant to override the captured scope, so that behaviour is unchanged.Testing:
'nonlocal' != 'local') and passes with it.locals={}passed, and a class that doesn't define the name.test_annotationlib,test_typing,test_inspect,test_dataclasses,test_type_annotations,test_functools,test_type_paramsandtest_pydocpass.